iSCSI digest support (CRC32C)

[Crusnik01]

Hi!

I'm trying to figure out if iPXE supports iSCSI header and/or data digest (CRC32C)?

Looking at the source code, it doesn't seem like it:

/src/net/tcp/iscsi.c

Code:

634 /**
635  * Build iSCSI login request strings
636  *
637  * @v iscsi             iSCSI session
638  *
639  * These are the initial set of strings sent in the first login
640  * request PDU.  We want the following settings:
641  *
642  *     HeaderDigest=None
643  *     DataDigest=None
644  *     MaxConnections is irrelevant; we make only one connection anyway [4]
645  *     InitialR2T=Yes [1]
646  *     ImmediateData is irrelevant; we never send immediate data [4]
647  *     MaxRecvDataSegmentLength=8192 (default; we don't care) [3]
648  *     MaxBurstLength=262144 (default; we don't care) [3]
649  *     FirstBurstLength=262144 (default; we don't care)
650  *     DefaultTime2Wait=0 [2]
651  *     DefaultTime2Retain=0 [2]
652  *     MaxOutstandingR2T=1
653  *     DataPDUInOrder=Yes
654  *     DataSequenceInOrder=Yes
655  *     ErrorRecoveryLevel=0
.
.
.
723         if ( iscsi->status & ISCSI_STATUS_STRINGS_OPERATIONAL ) {
724                 used += ssnprintf ( data + used, len - used,
725                                     "HeaderDigest=None%c"
726                                     "DataDigest=None%c"

Line 725 and 726 seem to hardcode "None" as the available digest methods, which in turn is the likely cause to generate the following error on my iSCSI box:

Code:

[2414549.983174] Proposer's value list "None" contains no valid values from Acceptor's value list "CRC32C".
[2414549.984696] iSCSI Login negotiation failed.

I see in the SCST mirror that is hosted on the git repository that it implements CRC32C support, though I'm unsure if this has been implemented in iPXE in any way?

Hope someone can shed some light on this. Thanks! =)

EDIT: The iPXE error that was returned after I enabled the digest settings on the iSCSI box: http://ipxe.org/err/410d61