Handling DHCP timeouts in script

[robinsmidsrod]

Your script is almost good. I believe the isset in the dhcp line starts a new conditional, so if dhcp fails, it will indeed exit.

I would do something like this instead:

Code:

:retry_dhcp
dhcp || goto retry_dhcp
isset ${filename} || goto retry_dhcp

Then again, I don't understand why you check if the ${filename} variable is set, when you don't use it later. I would just skip that line, as it doesn't really make any difference in your script. After all, if the dhcp fails to retrieve an IP it will fail and go back to retry_dhcp.

You might want to consider jumping back to :retry_dhcp instead of :iscsiboot if the sanboot fails, as it will just be standing there looping on trying to connect to the same target if it isn't able to connect. Depending on your setup, that might be exactly what you want, but redoing the dhcp and trying to connect again seems like a more robust setup.