wimboot and vdisk_name_len 31 macro

[Mad Butcher]

I like winboot's functionality added by this commit:
https://git.ipxe.org/wimboot.git/commit/...5ae01eeb23

It allow to inject additional files to the loaded WIM, but I want to use long filenames when I add files. I looked at sources and saw in the vdisk.h file 'vdisk_name_len 31' macro.
Is it restriction for virtual disk file system or something else?
Why length set to 31?

I ask this question, because increasing this value to 64 (for example) is don't look like breaking down wimboot functionality.

P.S.
I was a little bit confused when build wimboot from source, because I didn't find any build instructions with description of the build targets, depences etc. These build instructions exist?

[mcb30]

(2018-08-02 09:15)Mad Butcher Wrote:  I like winboot's functionality added by this commit:
https://git.ipxe.org/wimboot.git/commit/...5ae01eeb23

It allow to inject additional files to the loaded WIM, but I want to use long filenames when I add files. I looked at sources and saw in the vdisk.h file 'vdisk_name_len 31' macro.
Is it restriction for virtual disk file system or something else?
Why length set to 31?

It has to be set to some figure, since there is no dynamic memory allocation within wimboot. The 31 is fairly arbitrary. Increasing to 63 (i.e. 64 when the NUL is included) would be fine, if there's a need for it.

Quote:I was a little bit confused when build wimboot from source, because I didn't find any build instructions with description of the build targets, depences etc. These build instructions exist?

The build instruction is just "run 'make' within the source directory".

Michael

[Mad Butcher]

Thanks for quick reply and explanation, Michael.

Could you please patch your repository to 63 length?
I think, 64 symbols (including terminated 0) ought to be enough for anybody)

P.S.
I asked for build instructions because yesterday I built wimboot and got a file size 41.6 KB that less at 10 KB than latest wimboot from http://git.ipxe.org/releases/wimboot/wimboot-latest.zip .
But now I guessed that difference it is signature size.